Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Overhaul our toolchain #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jan 3, 2025
Merged

Overhaul our toolchain #137

merged 22 commits into from
Jan 3, 2025

Conversation

@lgarron
Copy link
Member

@lgarron lgarron commented Jan 2, 2025 •
edited by jfly
Loading

This is a reworking of: #112

  • Replace gulp with a build on fantasticon.
  • Update package exports to match.
  • Generate icons.cubing.net from the built lib.
    • Remove Bootstrap and modernize the docs.
  • Adopt bun for faster building, running uncompiled TypeScript scripts, and keeping dependencies up to date cheaply.

The SVG fonts aren't a 100% pixel-perfect alignment match to what they were before, but I've adjusted things so that they should be very close to a drop-in replacement.

Things that require fixing before merging:

  • Figure out what to do about nix compat with @jfly
  • Include the latest SVGs from main.
  • Fix up SVGs that relied on painting white instead of boolean operations.
  • Update README.md.

Fixes #55 and #93

@lgarron
Use fantasticon instead of gulp.
4799984 
Compared to our `gulp` pipeline, this is:

- Faster
- Much simpler
- Easier to maintain
- Not full of deprecated dependencies with vulnerabilities

This also changes the project organization to match other `github.com/cubing` projects more closely.

Closes:
- #55
- #93
@lgarron
Remove potrace installation from CI.
b66a548
@lgarron
Update actions/checkout to v4.
b8ce19f
@lgarron
Merge branch 'lgarron/biome' into lgarron/ungulp
4658d9a
@lgarron
Add make reset.
0bbdd1d
@lgarron
Fix make update-Makefile
19384c7
@lgarron
Bump deps.
6587994
@lgarron
Use bun and use make for dependent tasks.
259910b
@lgarron
Fix up site and TS build.
aa7be85
@lgarron
Update workflows (matching conventions from cubing.js).
acec7f2
@lgarron
Fix linting ignore.
b51d01f
@lgarron
Update SVGs from main.
6cd15f7
@lgarron
Merge branch 'main' into lgarron/ungulp
7d1b4b8
@lgarron
Fix up some icons to be flat SVG paths.
7114b44
@lgarron lgarron force-pushed the lgarron/ungulp branch 7 times, most recently from 4de78e6 to 614efb0 Compare January 2, 2025 16:51
@lgarron
Copy link
Member Author

lgarron commented Jan 2, 2025

Here's a screenshot of the updated generated site:
localhost_8000_dist_web_icons cubing net_

jfly
jfly reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I dm-ed you about re-nixifying this. (I'm running into an issue where the lockfile you've committed is missing an integrity hash).

The website redesign looks great, but I do have some feedback. How hard would it be to pull that into a separate PR so we can focus this PR entirely on harmonizing the nix stuff with the bun stuff?

@lgarron
Copy link
Member Author

lgarron commented Jan 3, 2025

The website redesign looks great, but I do have some feedback. How hard would it be to pull that into a separate PR so we can focus this PR entirely on harmonizing the nix stuff with the bun stuff?

Not too hard, but I don't want to touch any old website code and we'd have to coordinate the branches to make sure it stays up to date.

@lgarron lgarron mentioned this pull request Jan 3, 2025
Merged
@lgarron
Copy link
Member Author

lgarron commented Jan 3, 2025

The website redesign looks great, but I do have some feedback. How hard would it be to pull that into a separate PR so we can focus this PR entirely on harmonizing the nix stuff with the bun stuff?

Not too hard, but I don't want to touch any old website code and we'd have to coordinate the branches to make sure it stays up to date.

Split into: #138

lgarron
lgarron commented Jan 3, 2025
View reviewed changes
lgarron
lgarron commented Jan 3, 2025
View reviewed changes
jfly and others added 2 commits January 2, 2025 23:11
@jfly @lgarron
Update README.md
ee74eec 
Co-authored-by: Lucas Garron <[email protected]>
@jfly
Ignore bun.lock as well
3068643 
It's coming as the new default in bun 1.2.0.
@lgarron
Copy link
Member Author

lgarron commented Jan 3, 2025

  • Fix up SVGs that relied on painting white instead of boolean operations.

I have this mostly done, but will address it in a followup PR.

@lgarron lgarron merged commit fca76be into main Jan 3, 2025
1 check passed
@lgarron lgarron deleted the lgarron/ungulp branch January 3, 2025 07:56
This was referenced Jan 3, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfly jfly jfly left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

npm audit is failing

3 participants

@lgarron @jfly