Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[backport] Fix: always switch to the submodule dir before checking git tag/commit #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[backport] Fix: always switch to the submodule dir before checking git tag/commit #8240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions install/cupy_builder/install_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,9 @@ def check_cub_version(compiler, settings):
# could be in a git submodule?
try:
# CuPy's bundle
cupy_cub_include = _cub_path
cupy_cub_include = os.path.join(
cupy_builder.get_context().source_root,
"third_party/cccl")
a = subprocess.run(' '.join(['git', 'describe', '--tags']),
stdout=subprocess.PIPE, stderr=subprocess.PIPE,
shell=True, cwd=cupy_cub_include)
Expand Down Expand Up @@ -578,7 +580,9 @@ def check_jitify_version(compiler, settings):
global _jitify_version

try:
cupy_jitify_include = _jitify_path
cupy_jitify_include = os.path.join(
cupy_builder.get_context().source_root,
"third_party/jitify")
# Unfortunately Jitify does not have any identifiable name (branch,
# tag, etc), so we must use the commit here
a = subprocess.run(' '.join(['git', 'rev-parse', '--short', 'HEAD']),
Expand Down