I did this

Quickly review code handling temporary files and get renamed to final output files.

I expected the following

The code not to leak files on error code paths.

In particular this is the only location that unlinks the temporary file (tempstore) on error:

I think would be smarter to remove this line and move the unlink to error: section by adding:

if(tempstore)
  unlink(tempstore);

I would have normally just PRd this but I'm a bit too busy atm.

curl/libcurl version

master

operating system

all