engine/backup.py: remove conditional code related to target_dir
#9998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66d4168 to
02da50d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9998 +/- ##
===========================================
- Coverage 81.98% 75.46% -6.53%
===========================================
Files 427 427
Lines 46243 46243
Branches 4132 4132
===========================================
- Hits 37913 34897 -3016
- Misses 8330 11346 +3016
🚀 New features to boost your workflow:
|
In `TaskExporter`, it is trivially obviated by using "" as the default directory. In `ProjectExporter`, target directories are not supported at all, so remove such parameters completely. Also, add/improve type annotations for all affected methods.
02da50d to
dcc113f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
In
TaskExporter, it is trivially obviated by using "" as the default directory. InProjectExporter, target directories are not supported at all, so remove such parameters completely.Also, add/improve type annotations for all affected methods.
How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.