Rafał's WIP PR branch #578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c0703e to
2189528
Compare
DRY up the secret finder into Resource class, making it more efficient while I'm at it (moving most processing into database).
It's more idiomatic Ruby and easier to track dependencies when resource finder is a memoized method instead of a before action hook.
…use member variable
…e member variable
conjur-jenkins
pushed a commit
that referenced
this pull request
Nov 22, 2024
CNJR-6109 Add update results to dryrun REST API Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my WIP branch because some say pull requests are somehow more visible than branches. Please do not merge this into anything under any circumstances.