fix rewriting of /api and / so they're not URL-decoded before proxying upstream #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderhoof
approved these changes
Jun 26, 2018
conjur-jenkins
pushed a commit
that referenced
this pull request
Nov 22, 2024
…CNJR-7203 Revert "Temporarily disable security scans"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes conjurinc/appliance#232
What does this pull request do?
Fixes the nginx location rules for
/apiand/to avoid decoding before proxying to the upstream.What background context can you provide?
This was first noticed because hosts can no longer authenticate.
Where should the reviewer start?
The Stack Overflow answer linked in the comments is probably worth a look.
How should this be manually tested?
I did an appliance build including this change. If you pull
registry2.itci.conjur.net/conjur-appliance:use-nginx-rewrite_20180626and follow the steps in the issue, you should see that a host can now authenticate.Screenshots (if appropriate)
Link to build in Jenkins (if appropriate)
https://jenkins.conjur.net/job/cyberark--conjur/job/use-nginx-rewrite_20180626/
Questions: