Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix module cleanup for global memoryview slices. #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2024
Merged

Fix module cleanup for global memoryview slices. #6276

merged 2 commits into from
Jun 30, 2024

Conversation

@scoder
Copy link
Contributor

@scoder scoder commented Jun 28, 2024

Previously, we called Py_VISIT() and Py_CLEAR() on them, which is wrong.

Probably needs backporting to 3.0.x.

@scoder
Fix module cleanup for global memoryview slices.
9a31328 
Previously, we called Py_VISIT() and Py_CLEAR() on them, which is wrong.
@scoder scoder mentioned this pull request Jun 28, 2024
Merged
@da-woods
Copy link
Contributor

da-woods commented Jun 28, 2024

In principle I think we should visit the memview attribute of memoryview slices (and in cdef classes too) since it does point to a reference-counted Python object that can participate in reference cycles.

With that said, I think not visiting it is better that generating invalid code, so this is definitely OK for now.

@scoder
Copy link
Contributor Author

scoder commented Jun 29, 2024

I think we should visit the memview attribute of memoryview slices

Done.

Haven't looked into cdef classes, though. Are you sure we're doing it incorrectly there?

@da-woods
Copy link
Contributor

da-woods commented Jun 29, 2024

I think we should visit the memview attribute of memoryview slices

Done.

Haven't looked into cdef classes, though. Are you sure we're doing it incorrectly there?

Yes. We're generating nothing though, rather than generating invalid code, so it isn't necessary an immediate problem.

@scoder scoder added this to the 3.1 milestone Jun 30, 2024
@scoder scoder modified the milestones: 3.1, 3.0.11 Jun 30, 2024
@scoder scoder merged commit 2cfdf70 into cython:master Jun 30, 2024
@scoder scoder deleted the fix_memslice_global_cleanup branch June 30, 2024 05:45
scoder added a commit that referenced this pull request Jun 30, 2024
@scoder
Fix module cleanup for global memoryview slices. (GH-6276)
6e37bea 
Previously, we called Py_VISIT() and Py_CLEAR() on them, which is wrong.

We now correctly traverse memory view slices with Py_VISIT(memoryviewslice->memview).
@scoder
Copy link
Contributor Author

scoder commented Jun 30, 2024

3.0.x commit is 6e37bea

@isc-adang isc-adang mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Code Generation defect

Projects

None yet

Milestone

3.0.11

Development

Successfully merging this pull request may close these issues.

2 participants

@scoder @da-woods