Avoid traversing constants with Py_VISIT() #6277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we called Py_VISIT() and Py_CLEAR() on them, which is wrong.
da-woods
reviewed
Jun 28, 2024
Contributor
da-woods
left a comment
There was a problem hiding this comment.
... otherwise looks good
Cython/Utility/ModuleSetupCode.c
Outdated
| #endif | ||
| // No-op macro for calling Py_VISIT() on known constants that can never participate in reference cycles. | ||
| // Users can define it to "Py_VISIT(obj)" to help in debugging reference issues. | ||
| #define __Pyx_VISIT_CONST(obj) |
Contributor
There was a problem hiding this comment.
If you want users to be able to define it, would it make sense to do ifndef?
Contributor
Author
|
If you want users to be able to define it, would it make sense to do `ifndef`?
Ah, yes, right, thanks. That was the intention and I forgot to actually do it. :)
|
…cipate in reference cycles.
Contributor
Author
|
Added macro option, rebased on #6276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #6276 since it needs the same fix.