-
Notifications
You must be signed in to change notification settings - Fork 103
feat(*): support RPC style #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89b2d78 to
8f89f9e
Compare
e95faff to
b6d5337
Compare
00b84a4 to
c53967d
Compare
c53967d to
c5b272f
Compare
|
@xpofei All comments addressed, PTAL |
|
/lgtm |
|
/approve |
|
@iawia002: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iawia002, xpofei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@iawia002: new pull request created: #388 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Add a new builder to support serve RPC style APIs:
The default builder is still RESTful builder, here is an example to use RPC builder:
And for generating API documentation for RPC style APIs, you need to add a
styletag to the descriptors file:Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @xpofei
Release note: