deps(optimize): bump optimize version #39684
Conversation
1997d74 to
74fb1b5
Compare
|
Could you provide some context about this PR Why was optimize excluded before ? |
| vault-secret-id: ${{ secrets.VAULT_SECRET_ID }} | ||
| - name: Build Maven | ||
| run: | | ||
| ./mvnw clean deploy -B -T1C -P -docker,skipFrontendBuild -DskipTests -DskipChecks -DaltStagingDirectory=${{ github.workspace }}/staging-${{ env.BRANCH_NAME }} -DskipRemoteStaging=true -Dmaven.deploy.skip=true -P\!include-optimize |
There was a problem hiding this comment.
could you please add to the PR descriptiom why this -P switch is being removed and what's the effect of it?
| <groupId>io.camunda</groupId> | ||
| <artifactId>zeebe-parent</artifactId> | ||
| <version>8.8.0-SNAPSHOT</version> | ||
| <version>8.8.1-SNAPSHOT</version> |
There was a problem hiding this comment.
does this mean that from now on, parent.version in this file must always match the version from pom.xml for zeebe-parent?
does it also mean Optimize and Monorepo must always be built in-sync, one after another for the 8.8.x patches (i.e. if 8.8.1 built for Monorepo, Optimize 8.8.1 also must be built - cannot be skipped, be another patch version etc.)?
There was a problem hiding this comment.
does this mean that from now on, parent.version in this file must always match the version from pom.xml for zeebe-parent?
I think yes, but I would like first to confirm with this first patch release.
does it also mean Optimize and Monorepo must always be built in-sync, one after another for the 8.8.x patches (i.e. if 8.8.1 built for Monorepo, Optimize 8.8.1 also must be built - cannot be skipped, be another patch version etc.)?
don't think so. This is zeebe referenced by the version generated by this build, we don't actively changed the optimize version, so I believe they can still be run separately with no version dependency.
| -D forkCount=7 -D skipITs -D skipQaBuild=true -D skipChecks -Dskip.docker | ||
| -D surefire.rerunFailingTestsCount=3 -D junitThreadCount=16 -P skipFrontendBuild | ||
| -P\!include-optimize | ||
| -pl '-:optimize-schema-integrity-tests' |
There was a problem hiding this comment.
How became it -pl '-:optimize-schema-integrity-tests' from -P\!include-optimize ? At other parts the negation was just removed
There was a problem hiding this comment.
Because that's what we had before the issue happened.
|
Successfully created backport PR for |
# Description Backport of #39684 to `release-8.8.1`. relates to
Description
This pull request primarily removes the usage of the
!include-optimizeMaven profile from all CI workflow jobs, sincezeebe-partentfor Optimize was bumped to8.8.1-SNAPSHOT, as we did in all other components on Monorepo, and now the Optimize module is able to findzeebe-partent, no need to be skipped.CI Workflow Simplification:
Removed the
-P\!include-optimizeMaven profile from all relevantci.yml,ci-operate.yml,ci-tasklist.yml,ci-webapp-run-ut-reuseable.yml, andci-zeebe.ymlworkflow jobs, simplifying the Maven command invocations and reducing unnecessary configuration complexity. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27]Reduced the timeout for the "General / Unit - Back End" job from 25 to 10 minutes in
ci.yml, likely to catch stuck jobs faster and optimize CI resource usage.Dependency Updates (Optimize Backend):
jakarta.xml.bind:jakarta.xml.bind-apitransitive dependency from a backend dependency inoptimize/backend/pom.xmlto prevent unnecessary or conflicting dependencies.com.github.wnameless.json:json-basefrom version 2.5.0 to 2.5.1 inoptimize/backend/pom.xmlfor bug fixes or improvements.optimize/pom.xmlfrom8.8.0-SNAPSHOTto8.8.1-SNAPSHOTto track the latest parent build.Checklist
Related issues
closes #