Thanks to visit codestin.com
Credit goes to github.com

Skip to content

map RESOLVE incident intent to ACTIVE incident state #39815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2025
Merged

map RESOLVE incident intent to ACTIVE incident state #39815

merged 3 commits into from
Oct 30, 2025

Conversation

@EuroLew
Copy link
Contributor

@EuroLew EuroLew commented Oct 21, 2025

Description

The client side does not know of any incident status RESOLVE, therefore it should instead map a RESOLVE incident intent to an ACTIVE incident status.

Related issues

closes #37288

@EuroLew EuroLew added the backport stable/8.8 Backport a pull request to stable/8.8 label Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025 •
edited
Loading

🧪 Flaky Tests Summary

👻 Haunted Tests — They Fail When No One's Watching

  • shouldBeAuthorizedToSaveDraftVariables

    • Jobs: opensearch-integration-tests
    • Package: io.camunda.it.tasklist.v1.task
    • Class: TasklistV1ApiUserTaskPermissionsIT
    • Pipeline runs: 5
    • Overall retries: 2 (per run: [0, 0, 1, 1, 0])

  • shouldRejectBroadcastForOneUnauthorizedProcess

    • Jobs: zeebe-unit-tests/General-CoreFeatures
    • Package: io.camunda.zeebe.engine.processing.signal
    • Class: BroadcastSignalMultiplePartitionsTest
    • Pipeline runs: 5
    • Overall retries: 2 (per run: [0, 1, 0, 0, 1])

  • getMappingRuleShouldReturnMappingRuleIfAuthorized

    • Jobs: elasticsearch-integration-tests, opensearch-integration-tests
    • Package: io.camunda.it.auth
    • Class: MappingRuleAuthorizationIT
    • Pipeline runs: 5
    • Overall retries: 2 (per run: [0, 0, 0, 0, 2])

  • getByKeyShouldReturnTenantOwnedProcessDefinition

    • Jobs: elasticsearch-integration-tests
    • Package: io.camunda.it.tenancy
    • Class: ProcessDefinitionTenancyIT
    • Pipeline runs: 5
    • Overall retries: 1 (per run: [1, 0, 0, 0, 0])

  • shouldReturnOnlyTenantAProcessDefinitions

    • Jobs: elasticsearch-integration-tests
    • Package: io.camunda.it.tenancy
    • Class: ProcessDefinitionTenancyIT
    • Pipeline runs: 5
    • Overall retries: 1 (per run: [1, 0, 0, 0, 0])

  • shouldRejectAdHocJobCompletionWhenAdHocSubProcessNotActive

    • Jobs: zeebe-unit-tests/General-CoreFeatures
    • Package: io.camunda.zeebe.engine.processing.bpmn.activity
    • Class: JobBasedAdHocSubProcessTest
    • Pipeline runs: 5
    • Overall retries: 1 (per run: [1, 0, 0, 0, 0])

  • shouldBePermittedToSearchUsingInternalApi

    • Jobs: opensearch-integration-tests
    • Package: io.camunda.it.operate
    • Class: OperateInternalApiRolePermissionsIT
    • Pipeline runs: 5
    • Overall retries: 1 (per run: [0, 0, 0, 0, 1])

If the changes affect this area, please check and fix before merging.
If not, leave a quick comment explaining why it's likely unrelated.

@github-actions github-actions bot added the outdated-branch This label is used by the Check Outdated PRs GH workflow. PRs behind 20 commits will be labelled. label Oct 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

🚨 This PR needs attention 🚨

This PR is currently 114 commits behind the main branch (threshold: 50). Please update your branch before this PR can be merged.

houssain-barouni
houssain-barouni reviewed Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@houssain-barouni houssain-barouni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EuroLew , thank you for the fix
💭 @tmetzke has suggested that the exporter should not process the records with this RESOLVE intent, cause it is coming from a command rather than a change of the actual state of the incident itself.
Can we consider updating PostImporterQueueFromIncidentHandler, and make handlesRecord check that the intent is different from RESOLVE, or better, that it is one of a Set of supported intents. This should prevent the problem where a zeebe intent is not handled as an incident state, in the Incident Update job

@EuroLew EuroLew force-pushed the el-map-all-incident-states branch from 031fc8f to 87da97b Compare October 23, 2025 14:25
RomanJRW
RomanJRW approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@RomanJRW RomanJRW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are fine, but there is an open question here that I would appreciate an answer on as it might resolve multiple open issues we have right now

@EuroLew EuroLew force-pushed the el-map-all-incident-states branch from 87da97b to 092baab Compare October 29, 2025 16:28
@EuroLew EuroLew added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 7e2dabd Oct 30, 2025
121 of 123 checks passed
@EuroLew EuroLew deleted the el-map-all-incident-states branch October 30, 2025 12:02
@backport-action
Copy link
Collaborator

backport-action commented Oct 30, 2025

Successfully created backport PR for stable/8.8:

@backport-action backport-action mentioned this pull request Oct 30, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@EuroLew
[Backport stable/8.8] map RESOLVE incident intent to ACTIVE incident …
a45c419 
…state (#40235)

# Description
Backport of #39815 to `stable/8.8`.

relates to #37288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomanJRW RomanJRW RomanJRW approved these changes

@houssain-barouni houssain-barouni Awaiting requested review from houssain-barouni

Assignees

No one assigned

Labels

backport stable/8.8 Backport a pull request to stable/8.8 outdated-branch This label is used by the Check Outdated PRs GH workflow. PRs behind 20 commits will be labelled. version:8.8.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NullPointerException in SearchQueryResponseMapper when IncidentEntity state is null

5 participants

@EuroLew @backport-action @RomanJRW @houssain-barouni