Allow different signing algorithms when creating a CSR #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b75c9b to
daf77ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 59.15% 59.49% +0.33%
==========================================
Files 10 10
Lines 928 995 +67
==========================================
+ Hits 549 592 +43
- Misses 312 328 +16
- Partials 67 75 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ba34d1 to
fc28fe9
Compare
fc28fe9 to
beed2cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, CSR generation had
x509.ECDSAWithSHA256hardcoded as theSignatureAlgorithm.This PR enables more signing algorithms to specify