feat: add --valid-days flag for certificate validity
#62
+105
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set NotBefore/NotAfter for self-signed certificates with default 2-year validity and -5 minute skew for clock drift tolerance. Rationale: Git x509 verification enforces time validity. Previously self-signed certs used zero-time, causing NotBefore/NotAfter=year 0001. HACD pipeline uses -no_check_time, but local git verification fails. Setting sane defaults fixes local UX. Future: Add CLI option to override validity duration.
Add CLI flag to control certificate validity period in days for self-signed certificates. - New flag: --valid-days <N> controls validity in days - Defaults to 730 days if omitted or <= 0 - Preserves -5m NotBefore skew for clock drift protection - Integrates with existing self-signed certificate generation
Only set NotBefore/NotAfter when ValidityDays > 0 is explicitly provided. Preserve original zero-time behavior when ValidityDays = 0 (default value). - Update CLI help text to clarify new behavior - Add comprehensive test coverage for both modes - Ensure existing workflows unchanged when flag not used - Fix regression from previous commit that changed defaults
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 57.72% 58.16% +0.43%
==========================================
Files 10 10
Lines 951 961 +10
==========================================
+ Hits 549 559 +10
Misses 335 335
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
--valid-daysCLI flag to control the validity period of self-signed certificatesIf omitted, pivit defaults to previous behavior for backwards compatibility
Motivation
Previously, self-signed certificates generated by pivit had zero
NotBeforeandNotAftertimes, which could cause issues with any tool that couldn't be set up toignore the validityChanges
--valid-days(integer) - specify validity period in days for self-signed certificates0(preserves existing zero-time behavior)NotBefore/NotAfterwith 5-minute negative skew for clock driftMore Change Details
--valid-days > 0: Sets properNotBeforeandNotAftertimes with 5-minute negative skew for clock drift tolerance--valid-days = 0(default): Preserves original behavior with zero times for backwards compatibility--self-signflag)Testing
TestGenerateCertificate_BackwardsCompatibility(): Verifies zero times when flag not usedTestGenerateCertificate_ValidityDays(): Validates proper validity period settingExample