Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Sraleik
Copy link
Contributor

@Sraleik Sraleik commented Feb 4, 2025

Description 🦫

I needed a Postgres adapter, could not find one, so I made it :)
Since I made it, might as well share it ^^

It's not perfect, but the test are green.

needed dependencies :

needed devDependencies:

Type of change 📝

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested? 🧑‍🔬

I copied the test from in memory adapter and I made them work on my implementation.
I use testcontainer to run a postgres and test against it (not sur it will run on CI but works great in local)

Checklist: ✅

I had to disable a few eslint rule to make it work

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasAribart
Copy link
Contributor

Awesome! Thank you @Sraleik, will have a look this week-end!

@ThomasAribart
Copy link
Contributor

@Sraleik LGTM! You should also:

@ThomasAribart ThomasAribart marked this pull request as ready for review February 11, 2025 15:29
@ThomasAribart ThomasAribart changed the title Postgres Adapter feature: Postgres Adapter Feb 11, 2025
@Sraleik
Copy link
Contributor Author

Sraleik commented Feb 11, 2025

👍 I'll do all that in the week :)

@Sraleik
Copy link
Contributor Author

Sraleik commented Feb 12, 2025

All done:

  • static method
  • release job
  • documentation

@Sraleik
Copy link
Contributor Author

Sraleik commented Feb 17, 2025

Hello, just a small ping here. I would very much prefer to use this library in my project rather than my fork. 🙏 :)

@ThomasAribart ThomasAribart merged commit 313e001 into castore-dev:main Feb 18, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants