Thanks to visit codestin.com
Credit goes to github.com

Skip to content

NumPy 2.x fixes #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2025
Merged

NumPy 2.x fixes #1513

merged 2 commits into from
Jan 9, 2025

Conversation

@berquist
Copy link
Member

I think this wasn't caught before because the CI images were generally failing to build with NumPy 2.0, so we weren't testing against it.

@berquist berquist added this to the v1.8.2 milestone Dec 23, 2024
@codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (98ff6b9) to head (c6e9c8a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cclib/method/ddec.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   81.44%   88.35%   +6.91%     
==========================================
  Files          73       73              
  Lines       14817    14817              
==========================================
+ Hits        12068    13092    +1024     
+ Misses       2749     1725    -1024

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berquist
Copy link
Member Author

berquist commented Jan 9, 2025

I'm not sure why coverage wasn't showing for the NINF modifications. I ran coverage locally and those lines are hit, though the replacements of PINF were not.

@berquist
Copy link
Member Author

berquist commented Jan 9, 2025

From the CI log for 3.11:

Run dorny/paths-filter@v3
  with:
    filters: methods:
    - 'cclib/cclib/method/**'
    - 'test/method/**'
  
    token: ***
    list-files: none
    initial-fetch-depth: 100
  env:
    VERSIONINGIT_FOR_PACKAGE_INDEX: true
/usr/bin/docker exec  1a71dfafe9d2444e9449c2891d648d8f4cd8b3ae5289ed932c9e1ab577bcd7c1 sh -c "cat /etc/*release | grep ^ID"
Fetching list of changed files for PR#1513 from Github API
  Invoking listFiles(pull_number: 1513, per_page: 100)
  Received 1 items
  [modified] cclib/method/ddec.py
Detected 1 changed files
Results:
Filter methods = false
  Matching files: none
Changes output set to []

???

@berquist
Copy link
Member Author

berquist commented Jan 9, 2025

Ah, it's 'cclib/cclib/method/**' and should instead be 'cclib/method/**'.

@berquist
Copy link
Member Author

berquist commented Jan 9, 2025

Fixed:

/usr/bin/docker exec  079634b9672a0bca7896d64c81683f4b880d0b0e72607cc21b4dd72da69c28ba sh -c "cat /etc/*release | grep ^ID"
Fetching list of changed files for PR#1513 from Github API
  Invoking listFiles(pull_number: 1513, per_page: 100)
  Received 2 items
  [modified] .github/workflows/test_and_package.yml
  [modified] cclib/method/ddec.py
Detected 2 changed files
Results:
Filter methods = true
Changes output set to ["methods"]

@berquist berquist added github_actions Pull requests that update GitHub Actions code continuous-integration Things related to GItHub Workflows or the continuous integration infrastructure labels Jan 9, 2025
@berquist berquist merged commit ef7774a into cclib:master Jan 9, 2025
26 of 27 checks passed
@berquist berquist deleted the numpy-2-fixes branch January 9, 2025 05:06
@berquist berquist mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

continuous-integration Things related to GItHub Workflows or the continuous integration infrastructure github_actions Pull requests that update GitHub Actions code maintenance

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

1 participant

@berquist