Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KhronosGroup/MoltenVK
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: cdavis5e/MoltenVK
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 8 files changed
  • 2 contributors

Commits on Jan 30, 2024

  1. MVKDevice: Support the nullDescriptor feature. 

    My testing shows that Metal satisfies all the conditions for the
`nullDescriptor` feature from `VK_EXT_robustness2`--even for buffers. I
suspect that Metal does something similar to the `__PAGEZERO` segment in
64-bit host programs--that is, all device memory is allocated above 4 GB
in case of null buffer pointers.

Unfortunately, Apple's videos on the subject indicate that this won't
fly with their validation layers.
    @cdavis5e
    cdavis5e committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6350e79 View commit details
    Browse the repository at this point in the history

  2. MVKPhysicalDevice: Set point size granularity to 1/8. 

    This is what it is in OpenGL on both my GPUs. I assume this is what
Metal uses.
    @cdavis5e
    cdavis5e committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    cb1dcdb View commit details
    Browse the repository at this point in the history

  3. MVKImage: Remove most remaining parameter validation code. 

    This is largely redundant with the validation layer, plus the values we
return from `vkGetImageFormatProperties()`. Only the combinations that
we can't forbid via `vkGetImageFormatProperties()` are still checked,
per the dev policy.
    @cdavis5e
    cdavis5e committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    877ef26 View commit details
    Browse the repository at this point in the history

  4. Add a function to query if a device supports presentation at all. 

    This function, `vkGetPhysicalDeviceMetalPresentationSupportEXT()`--which
I really need to add to the `VK_EXT_metal_surface` spec--will allow
clients to query if a physical device **can** be used to present
swapchain images at all, without needing to create a surface first. On
Mac, it returns the negated value of the `isHeadless` property; on iOS,
it always returns `true`.
    @cdavis5e
    cdavis5e committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    138d474 View commit details
    Browse the repository at this point in the history

  5. MVKImage: Fix build pre-Xcode 12.

    @cdavis5e
    cdavis5e committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    616b714 View commit details
    Browse the repository at this point in the history

  6. Common: Include <Availability.h>. 

    To ensure that platform macros are defined.
    @cdavis5e
    cdavis5e committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6933ab0 View commit details
    Browse the repository at this point in the history
Loading