Limit the lifetime of rogue processes #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliLay
approved these changes
Jul 7, 2022
Collaborator
|
I agree, introducing a timeout is a good idea, we nevertheless have to search for the issue why certain threads seems to be stuck. |
wmann-celonis
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will limit the lifetime of rogue compilation processes on the server (and theoretically also on the client), that will over time lead to an inevitable
Not accepting new connection, as max limit of #X connections is already reached.soft lock.The fix itself simply compensates the effects of an underlying issue but does not yet solve it. While intended as a temporary solution, I still think having a general timeout on compilation processes in the future remains beneficial.