CPL-6979: Fix makefile for Ubuntu 22.04 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spirsch
approved these changes
Jul 8, 2022
requirements.txt
Outdated
| black | ||
| mypy>=0.931 | ||
| posix_ipc | ||
| posix_ipc==0.9.8 |
Collaborator
There was a problem hiding this comment.
I'd like to add an explicit reasoning comment here so that in the future we might check for an updated version.
Suggested change
| posix_ipc==0.9.8 | |
| # fixed version due to outdated package: https://packages.ubuntu.com/jammy/python-posix-ipc | |
| posix_ipc==0.9.8 |
| cp $(DEBIAN_SRC)/compat debian/compat | ||
|
|
||
| echo "-- Building client .deb package" | ||
| dpkg-buildpackage -rfakeroot -uc -us |
Collaborator
There was a problem hiding this comment.
I just had a quick look into the options here, but signing (and .buildinfo and .changes files) is probably currently not important and will only be required when we want to properly release our package, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, generally, to make it Debian compliant, I think we have to add some more files and make some changes. I guess a good starting point is https://www.debian.org/doc/manuals/maint-guide/dreq.en.html, but Willi knows more for sure
wmann-celonis
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-layoutflag inpython3-setuptoolspackage)python3-posix-ipcto the homcc client Debian package and downgradedposix-ipcto latest available Ubuntu package version