Explicit remote compilation timeout #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmann-celonis
approved these changes
Jul 13, 2022
OliLay
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #32.
Since aLocalHostSemaphore's overall waiting time is indefinite, local compilations might exceed the specified timeout of 3min.Although such a long running execution is unwanted and should be unlikely with a well configured setup, the user and not the
clientprogram itself should be actively cancelling the process if required. Whereas on theserverwe should still limit the execution time to prevent rogue processes, especially since theclientwould already interpret this timeouting as anRemoteCompilationTimeoutErrorafter 1min and recover via the local compilation fallback.EDIT:
LocalHostSemaphoreis not at fault for the behavior I experienced during testing, further investigation is required!Underlying problem might simply not be fixable if the user has a faulty setup.