Thanks to visit codestin.com
Credit goes to github.com

Skip to content

while I set General Config Disabled=true, err_concurrency_limit_reject still occur #52

@wangzz719

Description

@wangzz719

While I set General Config Disabled=true, err_concurrency_limit_reject still occur.
The code shows:

if c.isEmptyOrNil() || c.threadSafeConfig.CircuitBreaker.Disabled.Get() {
		return runFunc(ctx)
	}

If Disabled is true, it will not stats run and fallback.
Here is my breaker create code:

manager := &CircuitManager{
	Manager: circuit.Manager{
		DefaultCircuitProperties: []circuit.CommandPropertiesConstructor{
			hystrixFactory.Configure,
		},
	},
}
breaker, err := manager.CreateCircuit(name)
if err != nil {
	breaker = manager.GetCircuit(name)
}

breaker.SetConfigThreadSafe(circuit.Config{
	General: circuit.GeneralConfig{
		Disabled: true,
	},
	Execution: circuit.ExecutionConfig{
		MaxConcurrentRequests: 10,
	},
	Fallback: circuit.FallbackConfig{
		MaxConcurrentRequests: 10,
	},
})

So why this happens?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions