Python 2/3 compatibiliy fixes #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed object.next() to next(object) and used six library to handle urlib.unquote -> urlib.parse.unquote issues, as well as dictionary viewkeys -> keys issue.
chapmanb
added a commit
that referenced
this pull request
Jan 31, 2015
Python 2/3 compatibiliy fixes
chapmanb
added a commit
that referenced
this pull request
Jan 31, 2015
Owner
|
Thanks so much for this. I pushed out a 0.6.2 release with the fixes. I also changed the viewkeys usage as that is not present in six 1.5.2 which ships with Ubuntu 14.04 packages. I think the new usage should be equivalent without requiring a more recent version. Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed object.next() to next(object) and used six library to handle urlib.unquote -> urlib.parse.unquote issues, as well as dictionary viewkeys -> keys issue.