Thanks to visit codestin.com
Credit goes to github.com

Skip to content

a file's mtime is not reliable when rotating log by datetime #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a file's mtime is not reliable when rotating log by datetime #135

wants to merge 1 commit into from

Conversation

@wangcn
Copy link

@wangcn wangcn commented Nov 28, 2016

test code

package main

import (
	"os"
	"time"
	"fmt"
)


func main() {
	t1 := time.Now()
	fmt.Println(t1)
	file, _ := os.Create("test.txt")
	stat, _ := file.Stat()
	t2 := stat.ModTime()
	fmt.Println(t2)
	fmt.Println(t2.Sub(t1))
}

t2 < t1.
my env: go1.7.3+openSUSE42.1+xfs
If rotating a log by comparing mtime and "now", the historical log may be overwritten multiple times and you lose it.

@lwithers lwithers mentioned this pull request Jan 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wangcn