bpf: lb: un-break terminating backends for service without backend #31840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue to forward traffic for established connections, even when a service loses its last active backends. This needs a small adjustment in a BPF test that was relying on this behaviour. Fixes: 1835011 ("bpf: drop SVC traffic if no backend is available") Signed-off-by: Julian Wiedmann <[email protected]>
Once a LB connection has been established, we expect to continue using its CT entry to obtain the backend. Even if the backend is in terminating state, and the service has lost all of its backends. Keeping this separate from the fix, in case we can't easily backport. Signed-off-by: Julian Wiedmann <[email protected]>
borkmann
approved these changes
Apr 8, 2024
Member
borkmann
left a comment
There was a problem hiding this comment.
Awesome, and thx for adding a unit test!
julianwiedmann
commented
Apr 8, 2024
Member
Author
|
/test |
This was referenced Apr 19, 2024
1 task
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussing with @borkmann we realized that service LB for established connections no longer works, if the service loses the last of its active backends. This was broken by #22388, which introduced the
svc->countcheck too early in the code path.