Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update CEPS watchdog bpf program loaded logger #31936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update CEPS watchdog bpf program loaded logger #31936

merged 1 commit into from
Jun 12, 2024

Conversation

@derailed
Copy link
Contributor

@derailed derailed commented Apr 12, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Given the inherent reconciliation to check on ceps bfp programs, using logs with error severity could be confusing. Also we currently don't log out the cep name which will help for further investigation.

  • Change logger from error to warning
  • Add cep name to log message

Signed-off-by: Fernand Galiana [email protected]

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 12, 2024
@derailed
Update CEPS watchdog
04671a9 
Given the inherent reconciliation to check on ceps bfp programs, using
logs with error severity could be confusing. Also we currently don't log
out the cep name which will help for further investigation.

* Change logger from error to warning
* Add cep name to log message

Signed-off-by: Fernand Galiana <[email protected]>
@derailed derailed force-pushed the pr/derailed/improve-ceps-watchdog branch from f7da862 to 04671a9 Compare April 12, 2024 17:14
@derailed
Copy link
Contributor Author

derailed commented Apr 12, 2024

/test

@derailed derailed marked this pull request as ready for review April 24, 2024 14:46
@derailed derailed requested a review from a team as a code owner April 24, 2024 14:46
@derailed derailed requested a review from nebril April 24, 2024 14:46
@github-actions
Copy link

github-actions bot commented May 26, 2024

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label May 26, 2024
@derailed derailed removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jun 3, 2024
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 12, 2024
@aanm aanm added this pull request to the merge queue Jun 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 12, 2024
Merged via the queue into cilium:main with commit 6aa1bc8 Jun 12, 2024
@christarazi christarazi added affects/v1.14 This issue affects v1.14 branch affects/v1.15 This issue affects v1.15 branch labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nebril nebril nebril approved these changes

Assignees

No one assigned

Labels

affects/v1.14 This issue affects v1.14 branch affects/v1.15 This issue affects v1.15 branch ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@derailed @nebril @christarazi @aanm