pkg/identity: Move GetCIDKeyFromK8sLabels to GlobalIdentity #32960
+86
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1701718 to
bc47d87
Compare
derailed
approved these changes
Jun 7, 2024
Contributor
derailed
left a comment
There was a problem hiding this comment.
@ovidiutirla Nice work!
9b9dd0e to
1b6992d
Compare
Moves the method from ciliumidentity package to GlobalIdentity and makes the method more generic by accepting the source to be used in mapping. Related cilium#27752 Signed-off-by: Ovidiu Tirla <[email protected]>
1b6992d to
374e78c
Compare
Contributor
Author
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the method from
ciliumidentitypackage to GlobalIdentity and makes the method more generic by accepting the source to be used in mapping.Related #27752