clustermesh: enable kvstoremesh by default #32912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13d17bf to
6e747ee
Compare
Contributor
Author
|
/test |
6e747ee to
ee642c0
Compare
Contributor
Author
|
/test |
ee642c0 to
8aa9be4
Compare
Contributor
Author
|
/test |
8aa9be4 to
d4d362a
Compare
thorn3r
approved these changes
Jun 6, 2024
Contributor
thorn3r
left a comment
There was a problem hiding this comment.
Just some nits on wording
qmonnet
approved these changes
Jun 7, 2024
Member
qmonnet
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Typo in the commit description, “visible adaptation by users” -> “adoption”? But that's not blocking.
d4d362a to
954ee79
Compare
Contributor
Author
|
/test |
Contributor
|
needs rebase :-/ |
Contributor
|
Are we confident that this is a safe upgrade path for running clusters, or should we gate this behind the |
954ee79 to
0c3dedb
Compare
Contributor
Author
|
Rebased.
I would say it's fairly safe. We have been testing this exact migration in CI for quite some time, but obviously there is always some risk.
|
Contributor
Author
|
/test |
0c3dedb to
be1cfae
Compare
Contributor
Author
|
/test |
Contributor
Author
|
Rebased |
squeed
approved these changes
Jun 12, 2024
KVStoreMesh has been introduced in v1.14. We have been running KVStoreMesh tests since then, while also testing upgrade path from "vanilla" Clustermesh to KVStoreMesh and back since then. There has been also a visible adaptation by users in community. Let's mark KVStoreMesh as stable and enable it by default. Note: Once 1.16 is out, we will need to update CI test Cilium Cluster Mesh upgrade (ci-clustermesh) Signed-off-by: Marcel Zieba <[email protected]>
be1cfae to
2cade99
Compare
Contributor
Author
|
/test |
Contributor
Author
|
Rebased to pick up some fixes for flaky ingress/gateway api test changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KVStoreMesh has been introduced in v1.14. We have been running KVStoreMesh tests since then, while also testing upgrade path from "vanilla" Clustermesh to KVStoreMesh and back since then. There has been also a visible adaptation by users in the community.
Let's mark KVStoreMesh as stable and enable it by default.
Note: Once 1.16 is out, we will need to update CI test Cilium Cluster Mesh upgrade (ci-clustermesh)
I am tagging @cilium/sig-clustermesh for visibility and waiting for lazy consensus by EOD 12th June GMT time.
For now, added the label
dont-merge/discussionfor lazy consensus.