Thanks to visit codestin.com
Credit goes to github.com

Skip to content

service: refactor monitoragent nil-checks #33069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

service: refactor monitoragent nil-checks #33069

merged 2 commits into from
Jun 13, 2024

Conversation

@mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Jun 11, 2024 •
edited
Loading 

service: unexport NewService
NewService is no longer used as the service manager is provided via
Hive Cell.

Therefore, this commit un-exports the function `NewService`.

service: remove monitoragent nil-check
Currently, accessing the monitoragent from the service manager is
guarded with nil-checks as unit-tests don't provide a monitoragent. (`NewService` is no longer exported)

This commit removes the check in favor of a fake implementation that
is used and passed in the tests.

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jun 11, 2024
@mhofstetter
service: unexport NewService
3697764 
NewService is no longer used as the service manager is provided via
Hive Cell.

Therefore, this commit un-exports the function `NewService`.

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter
service: remove monitoragent nil-check
9151455 
Currently, accessing the monitoragent from the service manager is
guarded with nil-checks as unit-tests don't provide a monitoragent.

This commit removes the check in favor of a fake implementation that
is used and passed in the tests.

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/svc-monitoragent-nilcheck branch from ead29bb to 9151455 Compare June 12, 2024 06:18
@mhofstetter
Copy link
Member Author

mhofstetter commented Jun 12, 2024

/test

@mhofstetter mhofstetter marked this pull request as ready for review June 12, 2024 09:34
@mhofstetter mhofstetter requested a review from a team as a code owner June 12, 2024 09:34
@mhofstetter mhofstetter requested a review from aspsk June 12, 2024 09:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2024
@aanm aanm added this pull request to the merge queue Jun 13, 2024
Merged via the queue into cilium:main with commit ec651ea Jun 13, 2024
@mhofstetter mhofstetter deleted the pr/mhofstetter/svc-monitoragent-nilcheck branch June 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aspsk aspsk aspsk approved these changes

Assignees

No one assigned

Labels

kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhofstetter @aspsk @aanm