Ipcache reopen on cilium restart #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebcb69f to
178cc0f
Compare
178cc0f to
f6c553b
Compare
mhofstetter
approved these changes
May 30, 2024
Member
mhofstetter
left a comment
There was a problem hiding this comment.
LGTM - thanks for the detailed commit messages!
Does the same issue exist with the conntrack map? (or does the Agent behaves differently for this map(s) (global & local)?
sayboras
reviewed
May 31, 2024
Member
Author
AFAIK conntrack maps are not recreated on agent restart. CT maps are populated by the datapath, so it would be rather hard to create a new one from the userspace. |
f6c553b to
8695b08
Compare
Member
Author
|
Also had to move the reopen to happen even if there is no difference in the policy! |
Date: 2024-05-31 16:38:45 +0200 Author: Jarno Rajahalme <[email protected]> Date: 2024-05-31 16:32:26 +0200 bpf: Allow reopening a map close any possible existing map before opening a new one. This allows Open() to be called again to reopen the map. Store the path passed to open() for later re-try during lookup(), it the open failed. Signed-off-by: Jarno Rajahalme <[email protected]>
Move ipcache singleton management from bpf_metadata.cc to ipcache.cc so that the sigleton can be accessed without going through bpf_metadata. This avoids Bazel import cycle in following commits. Add a new static methods to ipcache to create and get the singleton. Signed-off-by: Jarno Rajahalme <[email protected]>
Make server factory context available by storing it in a member. Signed-off-by: Jarno Rajahalme <[email protected]>
Add GrpcMuxImpl wrapper class to get access to onStreamEstablished(), and implement isNewStream() that returns 'true' on the first call after a new stream has been established. Signed-off-by: Jarno Rajahalme <[email protected]>
Reopen ipcache map each time after a new gRPC stream has been established for Network Policy Discovery Service. This is necessary to get access to the new IP Cache map Cilium Agent creates on restart. Signed-off-by: Jarno Rajahalme <[email protected]>
8695b08 to
73dc7da
Compare
sayboras
approved these changes
May 31, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen ipcache whenever a new NetworkPolicy stream is opened. This way we get access to the new ipcache after cilium agent restart.