invalid memory address or nil pointer dereference in formattedReviewerState #934
Description
Describe the bug
Attempt to view certain pull requests fails while attempting to print formattedReviewerState.
> gh --version
gh version 0.8.0 (2020-05-11)
Steps to reproduce the behavior
Reproduced while running gh pr view for a particular PR.
Unfortunately I cannot share further information about the request. It is in a private repository.
I can say that the PR did have reviewers (4) and that none had approved.
Expected vs actual behavior
Result is a runtime failure with the output provided in the next section.
Logs
REDACTED_ISSUE_TITLE
Open • REDACTED_USER_NAME wants to merge 1 commit into master from REDACTED_BRANCH_NAME
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x173af80]
goroutine 1 [running]:
github.com/cli/cli/command.formattedReviewerState(0xc0002837a0, 0xc0005c8e80, 0x17)
/home/runner/work/cli/cli/command/pr.go:505 +0xf0
github.com/cli/cli/command.prReviewerList(0xc0005c8e40, 0x20, 0x260f, 0xc000940f80, 0x3d, 0xc000357974, 0x4, 0x0, 0xc00061a480, 0x30, ...)
/home/runner/work/cli/cli/command/pr.go:516 +0x14c
github.com/cli/cli/command.printPrPreview(0x1a8da80, 0xc00000e018, 0xc0004664e0, 0x7ffeefbffb23, 0x4)
/home/runner/work/cli/cli/command/pr.go:436 +0x46b
github.com/cli/cli/command.prView(0x1fb1020, 0xc0003cd7c0, 0x1, 0x1, 0x0, 0x0)
/home/runner/work/cli/cli/command/pr.go:346 +0x2fc
github.com/spf13/cobra.(*Command).execute(0x1fb1020, 0xc0003cd690, 0x1, 0x1, 0x1fb1020, 0xc0003cd690)
/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:840 +0x453
github.com/spf13/cobra.(*Command).ExecuteC(0x1faee00, 0x5, 0x0, 0x0)
/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:945 +0x317
main.main()
/home/runner/work/cli/cli/cmd/gh/main.go:32 +0xde