From 359b4a1d637e31e86e0645385b04f9c74c89b944 Mon Sep 17 00:00:00 2001 From: Azeem Sajid Date: Tue, 28 Jan 2025 17:18:30 +0500 Subject: [PATCH 1/2] Stop progress indicator on failure (`gh run list --workflow`) --- pkg/cmd/run/list/list.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/cmd/run/list/list.go b/pkg/cmd/run/list/list.go index 793bfbb856e..0b291fae530 100644 --- a/pkg/cmd/run/list/list.go +++ b/pkg/cmd/run/list/list.go @@ -131,6 +131,7 @@ func listRun(opts *ListOptions) error { filters.WorkflowID = workflow.ID filters.WorkflowName = workflow.Name } else { + opts.IO.StopProgressIndicator() return err } } From de7c40789ef082fbf13f4a6cdaa504c95c176fe9 Mon Sep 17 00:00:00 2001 From: Azeem Sajid Date: Wed, 29 Jan 2025 08:22:32 +0500 Subject: [PATCH 2/2] Use `defer` instead --- pkg/cmd/run/list/list.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/run/list/list.go b/pkg/cmd/run/list/list.go index 0b291fae530..3113fdabd72 100644 --- a/pkg/cmd/run/list/list.go +++ b/pkg/cmd/run/list/list.go @@ -119,6 +119,8 @@ func listRun(opts *ListOptions) error { } opts.IO.StartProgressIndicator() + defer opts.IO.StopProgressIndicator() + if opts.WorkflowSelector != "" { // initially the workflow state is limited to 'active' states := []workflowShared.WorkflowState{workflowShared.Active} @@ -131,7 +133,6 @@ func listRun(opts *ListOptions) error { filters.WorkflowID = workflow.ID filters.WorkflowName = workflow.Name } else { - opts.IO.StopProgressIndicator() return err } }