Integrate license checks back into lint workflow #12112
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates license checking from an automated generation workflow into the existing lint workflow. Instead of automatically regenerating and committing license files on push to trunk, the PR shifts to a validation-only approach where CI checks that license files are up-to-date and developers must manually regenerate them when needed.
Key changes:
- Removed automated license regeneration workflow (
third-party-licenses.yml) - Added license validation to the lint workflow that runs on both pushes and pull requests
- Added path triggers for license-related files to ensure changes are validated
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/third-party-licenses.yml |
Removed automated workflow that regenerated and committed license files on push to trunk |
.github/workflows/lint.yml |
Added license validation step and path triggers for license-related files to check licenses are up-to-date |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added a comment specifying the installed go-licenses commit corresponds to v2.0.1 for clarity in the lint workflow.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Reverts #11370
Our third party license workflow doesn't work because it operates on trying to push to trunk directly, but our rulesets prevent this; something that was overlooked in #11370.
This moves it back to a link check, making it so maintainers need to manually update licenses in dependabot PRs and other PRs that update the
go.mod.