chore(deps): upgrade base-x to v5 (#897)

Copilot · fengmk2 · web-flow · commit d3e4fae69558 · 2025-12-06T21:20:36.000+08:00
Addresses #864 - upgrades `base-x` from v3 to v5. ## Breaking Change `base-x` v5 returns `Uint8Array` from `decode()` instead of `Buffer`. The `Buffer.readUInt32BE()` method doesn't exist on `Uint8Array`. ## Changes - **package.json**: `base-x` `^3.0.11` → `^5.0.0` - **app/common/UserUtil.ts**: Use `DataView` to read the CRC32 value from decoded bytes ```typescript // Before (v3 - Buffer) return crcBytes.readUInt32BE(0) === crc32(bytes); // After (v5 - Uint8Array) const dataView = new DataView(crcBytes.buffer, crcBytes.byteOffset, crcBytes.byteLength); return dataView.getUint32(0, false) === crc32(bytes); ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `https://api.github.com//advisories` > - Triggering command: `/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js` (http block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/cnpm/cnpmcore/settings/copilot/coding_agent) (admins only) > > </details>  <details> <summary>Original prompt</summary> > fix #864, upgrade base-x to v5 </details>  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
diff --git a/app/common/UserUtil.ts b/app/common/UserUtil.ts
@@ -23,7 +23,9 @@ export function checkToken(token: string, prefix: string): boolean {
   try {
     const bytes = base62.decode(splits[1]);
     const crcBytes = base62.decode(splits[2]);
-    return crcBytes.readUInt32BE(0) === crc32(bytes);
+    // base-x v5 returns Uint8Array instead of Buffer, use DataView to read UInt32BE
+    const dataView = new DataView(crcBytes.buffer, crcBytes.byteOffset, crcBytes.byteLength);
+    return dataView.getUint32(0, false) === crc32(bytes);
   } catch {
     return false;
   }
diff --git a/package.json b/package.json
@@ -93,7 +93,7 @@
     "@fengmk2/tar": "^6.2.0",
     "@node-rs/crc32": "^1.10.6",
     "@simplewebauthn/server": "^7.4.0",
-    "base-x": "^3.0.11",
+    "base-x": "^5.0.0",
     "base64url": "^3.0.1",
     "bson-objectid": "^2.0.4",
     "dayjs": "^1.11.19",
