-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Open
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-release-26.2Used to mark GA and release blockers, technical advisories, and bugs for 26.2Used to mark GA and release blockers, technical advisories, and bugs for 26.2
Description
Summary
The cluster setting bulkio.import.row_count_validation.unsafe.mode is currently off by default. Once INSPECT is stable, we should change the default to async so that IMPORT automatically validates the imported data in the background.
Context
There is a TODO in pkg/sql/importer/import_job.go:136:
// TODO(janexing): tune the default to async when INSPECT is merged in stable release.This validation is important because:
- For tables with secondary indexes, index consistency checks provide coverage
- For tables with only a primary index, row count validation is the primary mechanism to verify IMPORT completeness
Work Required
- Remove the
settings.WithUnsafeflag from the setting registration - Change the default value from
offtoasync - Remove the
unsafefrom the setting name (will require a migration/rename) - Add
settings.WithPublic, and regenerate docs with./dev gen docs
Related: #155472
Epic CRDB-58692
Jira issue: CRDB-58775
Metadata
Metadata
Assignees
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-release-26.2Used to mark GA and release blockers, technical advisories, and bugs for 26.2Used to mark GA and release blockers, technical advisories, and bugs for 26.2