Thanks to visit codestin.com
Credit goes to github.com

Skip to content

import: enable row count validation by default #161279

@rafiss

Description

@rafiss

Summary

The cluster setting bulkio.import.row_count_validation.unsafe.mode is currently off by default. Once INSPECT is stable, we should change the default to async so that IMPORT automatically validates the imported data in the background.

Context

There is a TODO in pkg/sql/importer/import_job.go:136:

// TODO(janexing): tune the default to async when INSPECT is merged in stable release.

This validation is important because:

  • For tables with secondary indexes, index consistency checks provide coverage
  • For tables with only a primary index, row count validation is the primary mechanism to verify IMPORT completeness

Work Required

  1. Remove the settings.WithUnsafe flag from the setting registration
  2. Change the default value from off to async
  3. Remove the unsafe from the setting name (will require a migration/rename)
  4. Add settings.WithPublic, and regenerate docs with ./dev gen docs

Related: #155472

Epic CRDB-58692

Jira issue: CRDB-58775

Metadata

Metadata

Assignees

Labels

C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-release-26.2Used to mark GA and release blockers, technical advisories, and bugs for 26.2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions