add max-pixel limit #832
Merged
add max-pixel limit #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrodmn
reviewed
Oct 14, 2025
Contributor
hrodmn
left a comment
There was a problem hiding this comment.
I think the mechanics of this change look good, but wonder if the 100_000_000 pixels default is right. 100_000_000 seems like a good starting point but would it make sense to set a maximum array size in bytes, then calculate the array size using the data type and the dimensions.
hrodmn
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #831
This PR adds a
MAX_PIXELSconstant which limit the shape of data array users could put in Memory (after a xarray.sel)