Clarify label translations and add new localization files #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies the “given name” label translations and adds full localization support for six new languages by introducing both fess_message_*.properties and fess_label_*.properties files.
- Clarified
labels.givenNametranslations (added parenthetical explanations) in supported locales. - Added complete message and label property files for Spanish, Italian, Dutch, Polish, Brazilian Portuguese, Simplified and Traditional Chinese.
- Updated Russian label file with the clarified
labels.givenName.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/resources/fess_message_*.properties | New message bundles for es, it, nl, pl, pt_BR, zh_CN, zh_TW |
| src/main/resources/fess_label_zh_TW.properties | New Traditional Chinese labels bundle |
| src/main/resources/fess_label_zh_CN.properties | New Simplified Chinese labels bundle |
| src/main/resources/fess_label_ru.properties | Updated Russian labels bundle for clarified givenName |
Comments suppressed due to low confidence (4)
src/main/resources/fess_label_zh_TW.properties:870
- Typo in key 'labels.surame'; it should be 'labels.surname' to match other locales and avoid missing label.
labels.surame=姓氏
src/main/resources/fess_label_zh_CN.properties:870
- Typo in key 'labels.surame'; it should be 'labels.surname' to match other locales and avoid missing label.
labels.surame=姓氏
src/main/resources/fess_label_ru.properties:870
- Typo in key 'labels.surame'; it should be 'labels.surname' to match other locales and avoid missing label.
labels.surame=Фамилия
src/main/resources/fess_label_ru.properties:868
- [nitpick] The update for 'labels.givenName' is applied only in the Russian locale; please apply similar clarifications to other locales (de, fr, ko) for consistency.
labels.givenName=Имя (данное имя)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
fess_label_*.propertiesandfess_message_*.properties.These changes enhance user interface clarity and extend internationalization support for broader accessibility.