refactor: add implicit run params parser #1783
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
commit: |
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the implicit run command parameter parsing to simplify the logic and remove manual argument filtering. The changes streamline how CLI arguments are processed when no explicit command is provided.
- Removes manual parsing of
--disable-analyticsand--verboseflags in favor of leveraging clap's built-in parsing - Simplifies argument construction by directly passing all trailing arguments to clap
- Updates the analytics flag handling to use parsed CLI parameters instead of environment variables
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crates/cli/src/main.rs
Outdated
| if cli.disable_analytics || std::env::var("DISABLE_ANALYTICS") == Ok("true".to_string()) { | ||
| let implicit_run_params = Cli::try_parse_from(cli.trailing_args.clone()); | ||
|
|
||
| if cli.disable_analytics || implicit_run_params.unwrap().disable_analytics { |
There was a problem hiding this comment.
The unwrap() call will panic if parsing fails. The code should handle the Result properly, either by using pattern matching or a safer method like unwrap_or_default() if there's a sensible default behavior.
| if cli.disable_analytics || implicit_run_params.unwrap().disable_analytics { | |
| if cli.disable_analytics | |
| || implicit_run_params | |
| .map_or(false, |params| params.disable_analytics) | |
| { |
crates/cli/src/main.rs
Outdated
|
|
||
| /// Disable telemetry | ||
| #[arg(long, global = true, action = clap::ArgAction::SetTrue)] | ||
| #[arg(long, global = true)] |
There was a problem hiding this comment.
Removing action = clap::ArgAction::SetTrue from a boolean flag will change its behavior. Boolean flags typically need this action to work correctly with clap, otherwise they may expect a value rather than acting as a toggle.
| #[arg(long, global = true)] | |
| #[arg(long, global = true, action = clap::ArgAction::SetTrue)] |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crates/cli/src/main.rs
Outdated
|
|
||
| // Set analytics flag from CLI or check if already set by handle_implicit_run_command | ||
| if cli.disable_analytics || std::env::var("DISABLE_ANALYTICS") == Ok("true".to_string()) { | ||
| let implicit_run_params = Cli::try_parse_from(cli.trailing_args.clone()); |
There was a problem hiding this comment.
The Cli::try_parse_from expects the first argument to be the program name, but cli.trailing_args likely doesn't include it. This will cause parsing to fail when the first trailing arg is treated as the program name instead of a command argument. Consider prepending a program name like vec![\"codemod\".to_string()] before the trailing args.
| let implicit_run_params = Cli::try_parse_from(cli.trailing_args.clone()); | |
| let implicit_run_params = Cli::try_parse_from({ | |
| let mut args = vec!["codemod".to_string()]; | |
| args.extend(cli.trailing_args.clone()); | |
| args | |
| }); |
There was a problem hiding this comment.
@mohebifar this is not true
crates/cli/src/main.rs
Outdated
| let implicit_run_params = Cli::try_parse_from(cli.trailing_args.clone()); | ||
|
|
||
| if cli.disable_analytics | ||
| || implicit_run_params |
There was a problem hiding this comment.
[nitpick] The variable name implicit_run_params is misleading since it contains the full CLI structure, not just run parameters. Consider renaming to implicit_cli_params or parsed_trailing_args to better reflect its content.
| let implicit_run_params = Cli::try_parse_from(cli.trailing_args.clone()); | |
| if cli.disable_analytics | |
| || implicit_run_params | |
| let implicit_cli_params = Cli::try_parse_from(cli.trailing_args.clone()); | |
| if cli.disable_analytics | |
| || implicit_cli_params |
📚 Description
🔗 Linked Issue
🧪 Test Plan
📄 Documentation to Update