-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Description
Error Message and Logs
The Coolify install.sh script aggressively manages /etc/docker/daemon.json to enforce logging standards and address pools. However, it does not robustly merge these settings with existing configurations.
If a user has pre-configured Docker to use a custom data directory (e.g., for persistent storage on a separate volume):
1 {
2 "data-root": "/mnt/data/docker"
3 }The installer overwrites this file with its own template (logging + address pools), causing Docker to lose the data-root setting.
Impact:
- Docker restarts and reverts to
/var/lib/docker(Root disk). - Any existing data on the custom volume is ignored.
- New data (volumes, images) fills up the root disk instead of the intended persistent volume.
- Infrastructure-as-Code setups (Terraform/Cloud-init) that configure storage before installing Coolify are broken.
To Reproduce
- Configure
/etc/docker/daemon.jsonwith{"data-root": "/mnt/data"}. - Run the Coolify install script:
curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash. - Check
cat /etc/docker/daemon.json.- Result:
data-rootkey is missing. - Expected:
data-rootshould be preserved, merged with Coolify's logging config.
- Result:
Proposed Solution
The installer should use jq (which it installs anyway) to securely merge the required logging/network config into the existing JSON file, rather than overwriting it with a static template.
Workaround
Currently, we have to implement a post-install hook to detect the overwrite, migrate any data created in /var/lib/docker during the installation window, and restore the correct daemon.json.
Steps to Reproduce
- Configure
/etc/docker/daemon.jsonwith{"data-root": "/mnt/data"}. - Run the Coolify install script:
curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash. - Check
cat /etc/docker/daemon.json.- Result:
data-rootkey is missing. - Expected:
data-rootshould be preserved, merged with Coolify's logging config.
- Result:
Example Repository URL
No response
Coolify Version
4.0.0-beta.454
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
Ubuntu 24.04 LTS
Additional Information
No response