fix(v4): fix Khmer and Ukrainian locales #5177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change kh to km and ua to uk
|
@ctoma is attempting to deploy a commit to the colinhacks' projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the language codes in line with ISO639, which we should try to follow wherever possible. It's better to fix this sooner rather than later.
Renamed Khmer from
khtokm(khis the ISO3166 code for Cambodia, not a valid ISO639 code).Renamed Ukrainian from
uatouk(uais their ISO3166 code, not their ISO639 code).https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes
This is a small breaking change, so should perhaps be tagged in v4.2
Thanks