Fix shape caching #5263
Fix shape caching #5263
Conversation
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on October 3
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| util.assignProp(this, "shape", shape ? util.objectClone(shape) : {}); | ||
| return this.shape; | ||
| }, | ||
| shape: shape!, |
There was a problem hiding this comment.
Bug: Object Function Shape Parameter Non-Null Assertion Bug
The object function's shape parameter is optional, but the new code uses a non-null assertion (shape!) for assignment. This assigns undefined to def.shape when no shape is provided, unlike the previous getter which defaulted to an empty object. This affects both mini and classic schemas and could cause runtime errors.
Additional Locations (1)
| $ZodType.init(inst, def); | ||
| // const sh = def.shape; | ||
| const desc = Object.getOwnPropertyDescriptor(def, "shape"); | ||
| if (!desc!.get) { |
There was a problem hiding this comment.
Bug: Missing Property Causes Runtime Error
If the 'shape' property is missing from def, Object.getOwnPropertyDescriptor() returns undefined. The non-null assertion desc!.get then attempts to access .get on undefined, which causes a runtime TypeError.
Fixes #5241