-
-
Notifications
You must be signed in to change notification settings - Fork 421
Avoid printing "Some()" and "null" in Server messages #5207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USing .orNull when we assume it can't be a null (because we checked above) is a bit misleading. We could use .get and make our assumption explicit. (Which could lead to failure after the next refactoring, though)
The .orNull is probably "safer", but I'd add a comment.
|
I think we check if they are the same as before, not if they are not null, so we may print |
|
If the option might be
IMHO, that doesn't matter. The code must be read and understood nevertheless. |
Consider we are already printing |
|
IMHO, I would fallback to the real used ones on the rhs, e.g. |
Use `0.0.0` for the unknown Mill version and `<system>` for the unspecified JVM version.
|
I changed it to use |
|
Maybe |
|
Thank you! @lefou |
No description provided.