[codec] Impl Encode for &[T: Encode]
#1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9914418 to
b60ec87
Compare
BrendanChou
previously approved these changes
Aug 29, 2025
b60ec87 to
6122d65
Compare
clabby
commented
Aug 29, 2025
BrendanChou
approved these changes
Aug 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 91.80% 92.07% +0.26%
==========================================
Files 280 283 +3
Lines 70653 73159 +2506
==========================================
+ Hits 64865 67361 +2496
- Misses 5788 5798 +10
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small addition to impl
Encodeon&[T: Encode], rather than requiring aVec<T: Encode>. Decoding still requires heap allocation.