-
Notifications
You must be signed in to change notification settings - Fork 471
merge_tree: proper check for subdirectory #4977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge_tree: proper check for subdirectory #4977
Conversation
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @woutdenolf. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#806), and ping the bot to refresh the PR. |
f86cee9 to
5c9eeb3
Compare
|
@conda-bot check-cla |
5c9eeb3 to
7d11395
Compare
|
For reference, this is a fix of another fix: #1546 |
varlackc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
|
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
1 similar comment
|
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
7d11395 to
7c54a95
Compare
|
I rebased again on main. |
CodSpeed Performance ReportMerging #4977 will not alter performanceComparing Summary
|
|
Well this is annoying? IIUIC, the test suite is failing on deprecations that have not been addressed within conda. That shouldn't block conda build PRs. Did I get that right? Ideas @jezdez @jaimergp @kenodegard ? |
|
@beckermr Yeah, we recently changed the |
|
Ah thank you @jezdez! |
Description
Closes #4976
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?