-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Open
Description
What happened:
Failing checks in #7728 due to module dependency version mismatch, see Circle-CI logs.
Run Kubernetes tests check fail with following error:
# github.com/coredns/ci/test/kubernetes [github.com/coredns/ci/test/kubernetes.test]
./metrics_test.go:87:15: undefined: expfmt.NewTextParser
FAIL github.com/coredns/ci/test/kubernetes [build failed]
FAILWhat you expected to happen:
It should pass.
How to reproduce it (as minimally and precisely as possible):
Create a change into a PR in https://github.com/coredns/coredns and see that check failing (This seems to not fail systematically).
Anything else we need to know?:
Either update all dependencies in https://github.com/coredns/ci or revert coredns/ci#165 by using var tp expfmt.TextParser instead of expfmt.NewTextParser.
Also, Consider adding comprehensive testing to https://github.com/coredns/ci
Environment:
N/A