This repository was archived by the owner on Feb 24, 2020. It is now read-only.
cat-manifest cmd for pods #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkt/pods.go
Outdated
There was a problem hiding this comment.
For consistency, we should return lower-cased errors here.
f47da88 to
f9c96dc
Compare
|
Added tests and made @iaguis suggested change. |
|
Tests fail :( |
rkt/enter.go
Outdated
There was a problem hiding this comment.
If you print the error direcly from the function it will be lower-cased, can you prefix it with some meaningful text?
We've had a cat-manifest for the ImageManifest but not for the PodManifest. This adds that missing functionality. Also added functional tests which required moving the previously wrongly named TestCatManifest to TestImageCatManifest. fixes rkt#1730
f9c96dc to
6393783
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a cat-manifest for the ImageManifest but not for the PodManifest. This adds that missing functionality.
There is also a bit of related refactoring included.
Should close issue #1730