Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

rkt: add --memory and --cpu to override isolators #1851

Merged
merged 1 commit into from
Dec 15, 2015
Merged

rkt: add --memory and --cpu to override isolators #1851

merged 1 commit into from
Dec 15, 2015

Conversation

@alban
Copy link
Member

@alban alban commented Dec 8, 2015

Fixes #1735

Depends on appc/spec#552 / appc/spec#553

@alban alban self-assigned this Dec 8, 2015
@alban alban added this to the v0.14.0 milestone Dec 8, 2015
@alban
Copy link
Member Author

alban commented Dec 8, 2015

TODO: add tests.

@alban alban force-pushed the alban/limit-cmdline branch from 8367f65 to 66fd872 Compare December 8, 2015 17:38
@alban alban mentioned this pull request Dec 8, 2015
Closed
@alban alban force-pushed the alban/limit-cmdline branch from 66fd872 to 88b2e74 Compare December 8, 2015 17:54
@alban
Copy link
Member Author

alban commented Dec 8, 2015

Updated with tests.

@iaguis
Copy link
Member

iaguis commented Dec 8, 2015

Pending on a spec release

iaguis
iaguis reviewed Dec 8, 2015
View reviewed changes
rkt/run.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should give more information here:

  • it's for the preceding app
  • syntax

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

OPTIONS:
      --cpu=                    cpu limit for the preceding image (example: '--cpu=500m')
      --exec=                   override the exec command for the preceding image
      --inherit-env[=false]         inherit all environment variables not set by apps
      --interactive[=false]         run pod interactively. If true, only one image may be supplied.
      --mds-register[=false]            register pod with metadata service. needs network connectivity to the host (--net=(default|default-restricted|host)
      --memory=                 memory limit for the preceding image (example: '--memory=16Mi', '--memory=50M', '--memory=1G')

@alban alban force-pushed the alban/limit-cmdline branch from 88b2e74 to 4fe70cc Compare December 9, 2015 11:08
@alban
Copy link
Member Author

alban commented Dec 9, 2015

Branch updated.

iaguis
iaguis reviewed Dec 9, 2015
View reviewed changes
rkt/cli_apps.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable*

@iaguis
Copy link
Member

iaguis commented Dec 9, 2015

LGTM after fixing the typo

@alban alban force-pushed the alban/limit-cmdline branch 2 times, most recently from 8da3780 to bd9060b Compare December 9, 2015 11:22
@jonboulle
Copy link
Contributor

someone please pick up #1859 :-)

@alban alban mentioned this pull request Dec 10, 2015
Merged
krnowak
krnowak reviewed Dec 11, 2015
View reviewed changes
rkt/cli_apps.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe print the value, so the user may get the clue immediately what is wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will update.

@jellonek
Copy link
Contributor

Little question - why this PR is adding 2 specific options (cpu, memory) instead of providing general purpose way of overriding values for isolators?

If in future we will have a way to limit I/O (storage, network) in some way, if we would have general purpose mechanism parsing small json part of manifest which would cover values from pod/apps manifests - there would be no need to add new parameters, codebase would be more compact, and probably it would be maintainable with less effort.

What You think about this?

@alban alban force-pushed the alban/limit-cmdline branch from bd9060b to b671960 Compare December 11, 2015 16:52
@alban
Copy link
Member Author

alban commented Dec 11, 2015

@jellonek I think that would be an increase of complexity in the UX... For the IO isolator, that would give something like:

$ rkt run image --isolator='{"name": "resource/block-bandwidth", "value": {"default": true, "limit": "2M"}'}

@alban
Copy link
Member Author

alban commented Dec 11, 2015

Rebased.

@iaguis
Copy link
Member

iaguis commented Dec 15, 2015

I agree with @alban

@iaguis
Copy link
Member

iaguis commented Dec 15, 2015

LGTM

iaguis added a commit that referenced this pull request Dec 15, 2015
@iaguis
Merge pull request #1851 from kinvolk/alban/limit-cmdline
00eb94e 
rkt: add --memory and --cpu to override isolators
@iaguis iaguis merged commit 00eb94e into rkt:master Dec 15, 2015
alban added a commit to kinvolk/rkt that referenced this pull request Dec 15, 2015
@alban
doc: --memory, --cpu
0106703 
The new rkt parameters --memory and --cpu were added without
documentation via rkt#1851.

Add the documentation.
@alban alban mentioned this pull request Dec 15, 2015
Merged
alban added a commit to kinvolk/rkt that referenced this pull request Dec 15, 2015
@alban
doc: --memory, --cpu
8f5dcde 
The new rkt parameters --memory and --cpu were added without
documentation via rkt#1851.

Add the documentation.
@achanda achanda mentioned this pull request Dec 21, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alban alban

Labels

area/usability component/stage0 kind/friction priority/P2 reviewed/lgtm

Projects

None yet

Milestone

v0.14.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alban @iaguis @jonboulle @jellonek @krnowak