image: Fix downloading image signatures from quay.io #1909
Conversation
|
Waiting for functional test. |
|
You mean you're writing one? Krzesimir Nowak [email protected] schrieb am Di., 22. Dez. 2015
|
|
Yes. |
fc9bf25 to
7857609
Compare
7857609 to
3d5de1a
Compare
|
Updated. |
|
@dgonyeo review? I'm curious whether it makes sense to start considering using acserver in here... |
The fetcher function was returning our special error for this case, but we "overwrote" it with fmt.Errorf in asc. So instead just forward the error.
We do not download the "prog.aci" anymore. The ACI was built everytime it was requested, so the process required to use go and actool. actool is still used for patching ACI manifest, but go is not used anywhere, so we can drop one environment variable too.
The stop channel is redundant. Instead, just listen to the closing of the message channel. Also, it was possible to build the ACI auth server as an executable binary. That was from the times, when I initially wrote it as a standalone tool. We don't use it anymore - the project also provides a library, which is better suits our tests better.
"AuthType", "AuthNone" is more descriptive than just "Type" and "None". Especially when new type enum is coming.
It asks to defer the signature file download until the image is downloaded first.
It will be used by the test for deferred signature file download.
… function Will be used by the test for the deferred signature file download.
It will be used also by the test checking the deferred signature download.
|
As far as acsever goes, you're welcome to use it but all it would do in this context is host static files. I think that's trivial enough to do in go that it's not worth adding the dependency. If rkt ends up gaining push support however, then there's be more value in adding it. |
3d5de1a to
a57e8de
Compare
|
Rebased to recent master. Also, it might be easier to review it commit by commit, since github didn't detect the renaming at one point. |
tests/testutils/aci-server/server.go
Outdated
There was a problem hiding this comment.
Aren't these the other way around?
There was a problem hiding this comment.
Nice catch. But git grepping shows that nothing uses the NewQuayServer function, and the only user of NewServer (the auth tests) actually does not care about it. I think I'll remove the NewServer and NewQuayServer functions, rename the NewServerFull function to NewServer and fix their uses accordingly.
The NewServer and NewQuayServer were either completely unused or just barely. Also, they mixed up the server type they created - NewQuayServer was creating an ordinary server, and NewServer - a Quay-like one.
|
Pushed the commit removing the functions. |
|
LGTM on green |
image: Fix downloading image signatures from quay.io
The fetcher function was returning our special error for this case,
but we "overwrote" it with fmt.Errorf in asc. So instead just forward
the error.
Fixes #1908
Cleaned up the auth ACI server (or was it ACI auth server?) by removing dead code, added the "quay mode", moved some functions from trust test into a common file (because they will be used in the new test) and wrote the test.