This repository was archived by the owner on Feb 24, 2020. It is now read-only.
Add size to api response #1916
Merged
Add size to api response #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Semaphore failure seems to be unrelated to my patch. |
api/v1alpha/api.proto
Outdated
There was a problem hiding this comment.
This seems like a tab indentation while the other lines are space indentation. I don't have strong preference on either, but we should keep consistency.
|
Small nits, LGTM, the semaphore failure looks like a flaky network issue, not related. |
70d1031 to
c200d4d
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #1872. This patch adds "Size" to the API response. It does not add annotations, I was planning on adding that in another PR but can fold it into this one if that's preferred.