Add annotations to api response #1924
Conversation
|
@derekparker Thanks for the PR! Sorry I should have made it clearer that we have annotations in three places:
This PR exports the annotations in the image manifest, but we also want to export annotations in the other two places, as in rktnetes we currently stored information both in the pod level annotations and the app level annotations. cc @jonboulle |
|
@yifan-gu sorry about that! I'll add in the other 2 places today and push to this branch. |
|
@derekparker SGTM :) No worries at all! |
7ffd3cf to
5cbccd3
Compare
|
pushed new changes, cc: @yifan-gu |
|
Sorry for the delay, will review after lunch. |
tests/rkt_api_service_test.go
Outdated
There was a problem hiding this comment.
@derekparker So since last couple of releases, --mds-register=false is the default, so we can delete that :)
|
@derekparker LGTM overall. After this, do you want to work on patch the rktnetes code to import the changes? |
|
@yifan-gu great, I'll make those changes soon and push them up. Also yes, I would like to work on patching the rktnetes code for these changes. |
@derekparker Sounds great! Thank you! FYI I am working on some refactoring on rktnetes and debugging kube-up with rkt as a runtime. Feel free to do refactoring when you patching rktnetes :) |
b01d5b1 to
0cf09ee
Compare
|
@yifan-gu pushed changes, added a TODO for the bug we discussed re hashes. |
|
@derekparker LGTM after squash. |
Adds Annotations to API response for Images, Pods and Apps. Fixes rkt#1872
0cf09ee to
e1bf976
Compare
|
@yifan-gu squashed. |
|
LGTM, I am working on a fix for the TODO. |
…onse Add annotations to api response
Partially fixes #1872, still need to address
ImageFiltercomment, unless we want to break that out into another issue.