rkt, config: Add loading configuration from user directory #1981
Conversation
Do we have a test that fetch images from several different users? E.g. 1 image fetched by 1 user, and deleted by another user, etc. |
|
The local configuration directory path is passed down to stage1. Should user config be passed there as well? This would allow us to override networking configuration. Not sure about the overriding semantics, that would be up to the stage1 implementation to decide I guess. |
12d4ae8 to
3b597fa
Compare
|
Non-root users can run |
hmm? what about for the aforementioned network example? |
I think that the problem here is that you think of |
|
Right. We need this for #1992 |
|
ping @robszumski about possible better name for the |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
- back quotes around
--user-config - link to the pull request
- link to the doc. "See rkt's Global Options documentation.
- why is it useful from a user perspective? E.g. fetching as user while keeping credentials in the user directory. Or using networking plugins installed in a different directory. (Is it correct?)
|
|
How about this test - https://github.com/coreos/rkt/blob/master/tests/rkt_non_root_test.go#L91 Is root there somehow special or can be treated as any other users in this case? |
|
@krnowak ok. So the test already exists :) |
e8f2b17 to
e5a86c8
Compare
|
Updated, for now I decided not to forward the user config path to stage1. This needs a bit more work. |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
s/Can be useful/It can be useful/
s/in the globally/in a globally/
|
LGTM after the nits |
e5a86c8 to
766743f
Compare
|
About config for stage1 - #2013. |
rkt, config: Add loading configuration from user directory
Fixes #1568.
This is rather a complete fix code-wise, though untested. Still need to update the documentation where necessary and probably add some functional tests.