functional tests: Add new test with systemd-proxyd #2257

borqosky · 2016-03-08T07:40:44Z

Setting ptp template network and IP address in systemd unit during
test. Updated also docs with example.

jellonek · 2016-03-08T09:25:35Z

Documentation/using-rkt-with-systemd.md

+
+`rkt` also supports [socket-proxyd service][systemd-socket-proxyd]. So, like in
+ socket activation systemd will listen on a port on behalf of a container, and start the container when receiving a connection. It could be useful to provide socket activation for enviroment that natively doesn't support it. One of the
+ example is the `KVM` flavour in `stage1`.


borqosky · 2016-03-30T09:37:18Z

review request...

jellonek · 2016-03-30T09:51:39Z

LFTM

alban · 2016-03-30T13:15:55Z

Documentation/using-rkt-with-systemd.md

+
+`rkt` also supports [socket-proxyd service][systemd-socket-proxyd]. So, like in
+ socket activation systemd will listen on a port on behalf of a container, and start the container when receiving a connection. It could be useful to provide socket activation for enviroment that natively doesn't support it. One of the
+ example is the `KVM` flavor in `stage1`.


s/enviroment/environment/

alban · 2016-03-30T13:29:04Z

tests/rkt_socket_proxyd_test.go

+	}
+	defer os.Remove(socketTarget)
+
+	// path to systemd-socket-proxyd on Ubuntu (different path on Fedora).


It seems to be available as well on Fedora.

$ rpm -qf /lib/systemd/systemd-socket-proxyd systemd-222-14.fc23.x86_64

alban · 2016-03-30T13:35:46Z

I didn't know systemd-socket-proxyd. It looks cool :)

@joshix , can you review the changes in Documentation/using-rkt-with-systemd.md? Thanks:)

borqosky · 2016-04-05T14:11:56Z

@joshix review request.

joshix · 2016-04-06T18:41:18Z

Documentation/using-rkt-with-systemd.md


+### Bidirectionally proxy local sockets to another (possibly remote) socket.
+
+`rkt` also supports [socket-proxyd service][systemd-socket-proxyd]. So, like in


rkt also supports the [socket-proxyd service][systemd-socket-proxyd]. Much like socker activation, with socket-proxyd systemd provides a listener on a given port on behalf of a container, and starts the container when a connection is received. Socket-proxy listening can be useful in environments that lack native support for socket activation. The LKVM stage1 flavor is an example of such an environment.

borqosky · 2016-04-08T10:01:03Z

@joshix review request.

joshix · 2016-04-08T17:58:49Z

Documentation/using-rkt-with-systemd.md


+### Bidirectionally proxy local sockets to another (possibly remote) socket.
+
+`rkt` also supports the [socket-proxyd service][systemd-socket-proxyd]. Much like socker activation, with socket-proxyd systemd provides a listener on a given port on behalf of a container, and starts the container when a connection is received. Socket-proxy listening can be useful in environments that lack native support for socket activation. The LKVM` `stage1 flavor is an example of such an environment.


s/socker/socket/

remove the backticks after "LKVM" and before "stage1"

joshix · 2016-04-08T18:00:31Z

@woodbor I have the two little nits noted inline. After those are fixed, the docs part LGTM. Thanks!

borqosky · 2016-04-11T06:46:59Z

done

alban · 2016-04-11T13:35:10Z

tests/rkt_socket_proxyd_test.go

@@ -0,0 +1,201 @@
+// Copyright 2015 The rkt Authors


alban · 2016-04-11T13:53:27Z

I also have two little nits noted inline. After that, LGTM.

Setting ptp template network and IP address in systemd unit during test. Updated also docs with example.

borqosky · 2016-04-12T06:39:37Z

done

alban · 2016-04-12T08:48:07Z

Thanks.
The TestFetch failure is not related to the patch.

borqosky changed the title ~~functional tests: Add new test with systemd-proxyd~~ [WIP]functional tests: Add new test with systemd-proxyd Mar 8, 2016

jellonek reviewed Mar 8, 2016
View reviewed changes

borqosky force-pushed the borkos/systemd_proxyd_test branch 2 times, most recently from bd5b40c to a97d768 Compare March 11, 2016 09:24

borqosky changed the title ~~[WIP]functional tests: Add new test with systemd-proxyd~~ functional tests: Add new test with systemd-proxyd Mar 11, 2016

borqosky force-pushed the borkos/systemd_proxyd_test branch from a97d768 to a48874b Compare March 23, 2016 13:10

alban reviewed Mar 30, 2016
View reviewed changes

borqosky force-pushed the borkos/systemd_proxyd_test branch from a48874b to d9448f3 Compare March 30, 2016 13:27

alban reviewed Mar 30, 2016
View reviewed changes

alban added area/networking technology/kvm needs/review technology/systemd labels Mar 30, 2016

alban added this to the v1.4.0 milestone Mar 30, 2016

borqosky force-pushed the borkos/systemd_proxyd_test branch 2 times, most recently from 3e2ea82 to 2fae589 Compare March 31, 2016 08:19

joshix reviewed Apr 6, 2016
View reviewed changes

alban added needs/some-changes and removed needs/review labels Apr 7, 2016

borqosky force-pushed the borkos/systemd_proxyd_test branch from 2fae589 to 46f6cbe Compare April 7, 2016 10:40

joshix reviewed Apr 8, 2016
View reviewed changes

borqosky force-pushed the borkos/systemd_proxyd_test branch from 46f6cbe to f009ada Compare April 11, 2016 06:45

jonboulle added needs/review and removed needs/some-changes labels Apr 11, 2016

alban reviewed Apr 11, 2016
View reviewed changes

tests/rkt_socket_proxyd_test.go Outdated

@@ -0,0 +1,201 @@

// Copyright 2015 The rkt Authors

Copy link

Member

alban Apr 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016

alban added needs/some-changes and removed needs/review labels Apr 11, 2016

functional tests: Add new test with systemd-proxyd

3d610d8

Setting ptp template network and IP address in systemd unit during test. Updated also docs with example.

borqosky force-pushed the borkos/systemd_proxyd_test branch from f009ada to 3d610d8 Compare April 12, 2016 06:39

alban added reviewed/lgtm and removed needs/some-changes labels Apr 12, 2016

alban merged commit 7aa709d into rkt:master Apr 12, 2016

borqosky deleted the borkos/systemd_proxyd_test branch April 12, 2016 09:04

alban mentioned this pull request Apr 15, 2016

TestSocketProxyd is racy #2432

Open


		### Bidirectionally proxy local sockets to another (possibly remote) socket.

		`rkt` also supports [socket-proxyd service][systemd-socket-proxyd]. So, like in


		### Bidirectionally proxy local sockets to another (possibly remote) socket.

		`rkt` also supports the [socket-proxyd service][systemd-socket-proxyd]. Much like socker activation, with socket-proxyd systemd provides a listener on a given port on behalf of a container, and starts the container when a connection is received. Socket-proxy listening can be useful in environments that lack native support for socket activation. The LKVM` `stage1 flavor is an example of such an environment.

Uh oh!

functional tests: Add new test with systemd-proxyd #2257

functional tests: Add new test with systemd-proxyd #2257

Uh oh!

Conversation

borqosky commented Mar 8, 2016

Uh oh!

jellonek Mar 8, 2016

Choose a reason for hiding this comment

Uh oh!

borqosky commented Mar 30, 2016

Uh oh!

jellonek commented Mar 30, 2016

Uh oh!

alban Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

alban Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

alban commented Mar 30, 2016

Uh oh!

borqosky commented Apr 5, 2016

Uh oh!

joshix Apr 6, 2016

Choose a reason for hiding this comment

Uh oh!

borqosky commented Apr 8, 2016

Uh oh!

joshix Apr 8, 2016

Choose a reason for hiding this comment

Uh oh!

joshix commented Apr 8, 2016

Uh oh!

borqosky commented Apr 11, 2016

Uh oh!

alban Apr 11, 2016

Choose a reason for hiding this comment

Uh oh!

alban commented Apr 11, 2016

Uh oh!

borqosky commented Apr 12, 2016

Uh oh!

alban commented Apr 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants